Open joeFischetti opened 3 years ago
agree that explicitly selecting a controller makes sense, will update to add. hope nobody had this in automation scripts since it's a breaking change.
Good point. Then again, it's not like we're not breaking various other parts of the project on a regular basis.
On Tue, Sep 7, 2021, 3:49 PM Brian Ledbetter @.***> wrote:
agree that explicitly selecting a controller makes sense, will update to add. hope nobody had this in automation scripts since it's a breaking change.
— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/bri3d/VW_Flash/issues/24#issuecomment-914579908, or unsubscribe https://github.com/notifications/unsubscribe-auth/AFCZ4XFRVIZVX6YPBLS7EVLUAZUFLANCNFSM5DSWR7JQ .
Since the project is getting larger and expanding to additional controllers (TCU, haldex), instead of doing --dsg, we should do --controller=dsg (and similarly, --controller=ECU). Defaults are good, but I wouldn't want to flash_bin my ECU with a TCU driver.
It's probably also a good opportunity to work in some additional idiot proofing (like flash_cal does) to at least prompt the user before potential crossflashing.