bri3d / VW_Flash

Flashing tools for VW AG control units over UDS. Compression, encryption, RSA bypass, and checksums are supported for Simos18.1/6/10, DQ250-MQB, DQ381-MQB, and Haldex4Motion-Gen5-MQB.
Other
315 stars 80 forks source link

Add Mode 22 and SL HSL Logging #64

Closed aarons3 closed 2 years ago

aarons3 commented 2 years ago

Adds Mode 22 and SL HSL logging capability Change default logging to mode 22 Add default logging list to get started Should work out of the box-- open GUI, start log, and will start logging mode 22. Tested with Openport and SocketCAN

bri3d commented 2 years ago

I'm fine with merging this - nice work!

We should remove the email functionality eventually as it adds a ton of clutter and confusion and nobody uses it, but that can come later.

One note: when I merge I am going to "squash" which means all of your commits will become one, so that the mainline doesn't have a bunch of "v1...v6" commits in it. This means you will want to check out a clean copy again on your end (or do some other more advanced git shenanigans) before you continue development, because the commits will have diverged.

aarons3 commented 2 years ago

Yeah it got a little messy. In the future would it be better for me to make a separate dev branch, merge/combined those into my master branch, then do the pull request?

bri3d commented 2 years ago

No, this method is fine, you'll just have to figure out your preferred way to take the changes back from my side once I've squashed them into a single commit. It's the same work either way :)