Closed ConnorHowell closed 2 years ago
Good catch with the threading problem, will need to look at where the progress bar update should live long term but I don't mind where you put it.
Thanks for the PR, I don't have major concerns if you'd like me to merge.
Yeah I think it's good to merge; I don't think it causes any unexpected side affects on other OS'
Done, thanks and welcome to the contributors list :)
Trying to search for interfaces in the GUI in MacOS results in the following crash:
To fix this I've had to move the update of the progress bar to the
ble_scan_callback
function, not sure if there is a cleaner fix for this.I've also added the lzss binary to the gitignore (this is handled for windows as all exe files are ignored).