bri3d / VW_Flash

Flashing tools for VW AG control units over UDS. Compression, encryption, RSA bypass, and checksums are supported for Simos18.1/6/10, DQ250-MQB, DQ381-MQB, and Haldex4Motion-Gen5-MQB.
Other
315 stars 80 forks source link

Preparations for building on MacOS #67

Closed ConnorHowell closed 2 years ago

ConnorHowell commented 2 years ago

Trying to search for interfaces in the GUI in MacOS results in the following crash:

objc[84681]: objc_removeExceptionHandler() called with unknown alt handler; this is probably a bug in multithreaded AppKit use. Set environment variable OBJC_DEBUG_ALT_HANDLERS=YES or break in objc_alt_handler_error() to debug. objc[84681]: objc_removeExceptionHandler() called with unknown alt handler; this is probably a bug in multithreaded AppKit use.

To fix this I've had to move the update of the progress bar to the ble_scan_callback function, not sure if there is a cleaner fix for this.

I've also added the lzss binary to the gitignore (this is handled for windows as all exe files are ignored).

bri3d commented 2 years ago

Good catch with the threading problem, will need to look at where the progress bar update should live long term but I don't mind where you put it.

Thanks for the PR, I don't have major concerns if you'd like me to merge.

ConnorHowell commented 2 years ago

Yeah I think it's good to merge; I don't think it causes any unexpected side affects on other OS'

bri3d commented 2 years ago

Done, thanks and welcome to the contributors list :)