Move unlocking to separate dialog

[ConnorHowell]

As discussed, this removes "Unlock ECU" from the dropdown list and moves it to separate navigation item with its own file picker to avoid cases of people accidentally selecting an unlock FRF to full flash.

[bri3d]

Looks OK. Probably need to update windows.md with new screenshots to prevent mass confusion

[ConnorHowell]

Looks OK. Probably need to update windows.md with new screenshots to prevent mass confusion

Made some tweaks to the docs and added a new screenshot for unlock. Can be seen here: windows.md. Might be worth enabling the Wiki feature in the repo and using that for docs now we've started adding a few other features, i.e. logging?

[mh254]

i guess, Wiki would be very good for documentation.

Am Mo., 31. Okt. 2022 um 13:42 Uhr schrieb Connor Howell - @. <github.mh254.230c640646.notifications# @.>:

Looks OK. Probably need to update windows.md with new screenshots to prevent mass confusion

Made some tweaks to the docs and added a new screenshot for unlock. Can be seen here: windows.md https://github.com/bri3d/VW_Flash/blob/625145e7a7a3b503fd3b6e8ce9cb881ec801eee7/docs/windows.md. Might be worth enabling the Wiki feature in the repo and using that for docs now we've started adding a few other features, i.e. logging?

— Reply to this email directly, view it on GitHub https://github.com/bri3d/VW_Flash/pull/80#issuecomment-1297029356, or unsubscribe https://github.com/notifications/unsubscribe-auth/AEIFVRWYSOIRB4QIVA5PNGLWF65E7ANCNFSM6AAAAAARRPCCLY . You are receiving this because you are subscribed to this thread.Message ID: @.***>

[bri3d]

Looks OK. Probably need to update windows.md with new screenshots to prevent mass confusion

Made some tweaks to the docs and added a new screenshot for unlock. Can be seen here: windows.md. Might be worth enabling the Wiki feature in the repo and using that for docs now we've started adding a few other features, i.e. logging?

Yes, not opposed at all to enabling the Wiki. The main reason I chose inline Markdown documentation before was to ensure that the documentation traveled more easily with the project in source or binary forms. But more "advanced" documentation in GitHub Wiki seems fine.

[bri3d]

I'm going to merge this and update the documentation a little to mention the old way also just before I do a release, to minimize the delta between the documentation on main and the latest release version's UI.

[ConnorHowell]

Just made some more changes from the couple of requests from yesterday; there's now a confirmation dialog on flashing, I've modified the file list to be single select (it's multiple select by default) and the selected item is now in bold to highlight it in the list. I also moved the index check for the file selection as this was causing that "Key Error" raised yesterday.