brian-j-smith
commented
7 years ago A few comments on the pull request:
- I added some commits that you should be able to squash into the request.
- The pull request is generating warnings (pollution.jl example) with the latest release of Mamba 0.110 for julia 0.6. Please revise the code to eliminate any warnings or errors.
- Consider renaming the
n_simsargument in thediscretediag()function tonsimto match the argument inABC()which similarly controls the number of generated datasets, as opposed to introducing a new argument name. Update code and documentation files accordingly. discretediag()attempts to automatically subset its AbstractChain argument to only those parameters with discrete support. The package cannot do this reliably, and may include parameters that are not discrete (pollution.jl example) or miss ones that are. The user will be able to make the proper distinction and can subset chains in a straightforward fashion (e.g.discretediag(sim1[:, :gamma, :])). Consider removing the automation. Update code and examples accordingly.- Some additional code formatting would be nice to ensure that line widths stay within 80 characters and that multi-line method argument declarations are aligned with the opening parentheses.
bdeonovic
Here is the discrete diagnostic code Brian. Let me know what you think needs fixing up/cleaning up. I didn't notice any tests or docs for the other diagnostics so I did not include any either.