brian-j-smith / Mamba.jl

Markov chain Monte Carlo (MCMC) for Bayesian analysis in julia
Other
253 stars 52 forks source link

Update to Julia v1.0 #145

Closed mohamed82008 closed 5 years ago

mohamed82008 commented 5 years ago

This PR upgrades Mamba to support Julia v1.0. Cheers!

mohamed82008 commented 5 years ago

Tests pass when on Gadfly master on my machine.

mohamed82008 commented 5 years ago

https://github.com/GiovineItalia/Gadfly.jl/issues/1203

brian-j-smith commented 5 years ago

@mohamed82008 Thank you so much for all the Mamba updates for compatibility with Julia 1.0. I'll start work on getting this pull request merged in when I get back home from travels later this week. Regards.

mohamed82008 commented 5 years ago

No worries. Thanks for the package!

brian-j-smith commented 5 years ago

The pull request is merged into master now along with some other compatibility updates needed to get the examples working with julia v1.0. Thanks again for the help. You must have spent a lot of time on the pull request. It really made the remaining updates go more quickly.

Cheers!