search

brian-team / brian

Brian is a simulator for spiking neural networks available on almost all platforms. This is the legacy version that is no longer developed, for new projects consider using Brian2 instead.
http://briansimulator.org
Other
60 stars 22 forks source link

Allow multiple realtime raster plots #1

Open sbrodeur opened 11 years ago

mstimberg commented 11 years ago

The patch looks good -- but I think it would be even greater if it could also fix the same issue for state monitor plots. Could apply your fix to StateMonitor.plot as well? This way, one could run for example https://github.com/brian-team/brian/blob/master/examples/misc/realtime_plotting.py in two figures instead of in two subplots. It also seems that RecentStateMonitor.plot and StateMonitor.plot do not have the newfigure keyword argument yet, for consistency it would be nice to have it there as well. If you see some opportunity for refactoring, i.e. removing some code duplication between raster_plot and StateMonitor.plot -- plase go ahead.

Sorry for becoming greedy :smile:, just tell us if you don't have time for the additional fixes.

sbrodeur commented 11 years ago

Hi Marcel,

That will be no problem! All the points/enhancements you mentioned are now on my TODO list. I previously had a harder time configuring the EGit plugin in Eclipse than applying modification to the code! ;-)

Simon

Am Montag, den 13.05.2013, 03:19 -0700 schrieb Marcel Stimberg:

The patch looks good -- but I think it would be even greater if it could also fix the same issue for state monitor plots. Could apply your fix to StateMonitor.plot as well? This way, one could run for example https://github.com/brian-team/brian/blob/master/examples/misc/realtime_plotting.py in two figures instead of in two subplots. It also seems that RecentStateMonitor.plot and StateMonitor.plot do not have the newfigure keyword argument yet, for consistency it would be nice to have it there as well. If you see some opportunity for refactoring, i.e. removing some code duplication between raster_plot and StateMonitor.plot -- plase go ahead.

Sorry for becoming greedy :smile:, just tell us if you don't have time for the additional fixes.

— Reply to this email directly or view it on GitHub.

Simon Brodeur Doctoral student Université de Sherbrooke, Canada Department of Electrical and Computer Engineering NECOTIS laboratory, C1-3036 Phone : (819) 821-8000 ext. 62187 Email: Simon.Brodeur@USherbrooke.ca

mstimberg commented 11 years ago

That will be no problem! All the points/enhancements you mentioned are now on my TODO list.

Cool, much appreciated!