Pass seed to binomial functions by reference, not value

brian-team / brian2genn

Brian 2 frontend to the GeNN simulator

http://brian2genn.readthedocs.io/

GNU General Public License v2.0

47 stars 16 forks source link

Pass seed to binomial functions by reference, not value #112

Closed kernfel closed 4 years ago

kernfel commented 4 years ago

Fixes #111

tnowotny commented 4 years ago

Hum ... mysteriously one test (test_synapse_generator_random) fails in one of the Mac pathways (Mac OSX python36) while absolutely everything else passes. I am inclined to ignore that failure. Otherwise, would recommend approval by @mstimberg to merge.

mstimberg commented 4 years ago

Looks good and reasonable to me. I found a bug in the test (in the main brian2 repository) that was supposed to make sure that PoissonInput does not lead to a constant input... :man_facepalming: Thanks for the fix, the OS X issue is odd but I don't think it has anything to do with this PR.