search

brian-team / brian2genn

Brian 2 frontend to the GeNN simulator
http://brian2genn.readthedocs.io/
GNU General Public License v2.0
47 stars 16 forks source link

Use new GeNN syntax in model #82

Closed neworderofjamie closed 5 years ago

neworderofjamie commented 5 years ago

Brian2GeNN has been using the GeNN 2.X syntax for defining models. This has continued to be supported via wrappers in GeNN 3.X, but all newer GeNN features (e.g. #57) and we plan on deprecating this syntax entirely in the next major release.

This PR updates the model.cpp template to use the new syntax.

neworderofjamie commented 5 years ago

@mstimberg I can't quite see how my changes could cause all Windows builds to fail - any thoughts?

mstimberg commented 5 years ago

Hi, I did not yet have time to look into the code changes, but the build failures certainly have nothing to do with them. It's failing during the conda installation step, there's something weird going on with "Access denied" errors. I tried to slightly change the conda environment setup, let's see whether this helps...

neworderofjamie commented 5 years ago

No rush! Having spent several days this week fiddling with our CI system I feel your pain...

mstimberg commented 5 years ago

Looks good to me, and I found a fix (at least temporary) for the build issue on the Windows test server, all tests pass now. I'll let the last (redundant, I think) tests run through before merging.