brianc / node-libpq

Simple, low level native bindings to PostgreSQL's libpq from node.js
112 stars 42 forks source link

Gyp rebuild issue #10

Closed jtaryma closed 9 years ago

jtaryma commented 9 years ago

Hi, I experienced an issue when re-running npm install in my project. Please see the log:

npm ERR! libpq@1.5.1 install: node-gyp rebuild npm ERR! Exit status 1 npm ERR! npm ERR! Failed at the libpq@1.5.1 install script. npm ERR! This is most likely a problem with the libpq package, npm ERR! not with npm itself. npm ERR! Tell the author that this fails on your system: npm ERR! node-gyp rebuild npm ERR! You can get their info via: npm ERR! npm owner ls libpq npm ERR! There is likely additional logging output above.

My node version: 0.10.29, gyp version 0.13.1.

SupremeTechnopriest commented 9 years ago

:+1: Im also seeing this on node 0.10 node 0.12 and iojs 1.6.3

SupremeTechnopriest commented 9 years ago

here is some more detailed output

> libpq@1.5.1 install /Users/rl/Sites/LumeFX/LumeFX-API/node_modules/pg-native/node_modules/libpq
> node-gyp rebuild

  CXX(target) Release/obj.target/addon/src/connection.o
In file included from ../src/connection.cc:1:
In file included from ../src/addon.h:5:
In file included from ../node_modules/nan/nan.h:63:
../node_modules/nan/nan_new.h:207:43: error: inline declaration of 'NanNew' follows
      non-inline definition
template <typename T> inline v8::Local<T> NanNew(v8::Handle<T> h);
                                          ^
../node_modules/nan/nan_implementation_pre_12_inl.h:210:1: note: previous definition is
      here
NanNew(v8::Handle<T> h) {
^
In file included from ../src/connection.cc:1:
In file included from ../src/addon.h:5:
In file included from ../node_modules/nan/nan.h:63:
../node_modules/nan/nan_new.h:208:43: error: inline declaration of 'NanNew' follows
      non-inline definition
template <typename T> inline v8::Local<T> NanNew(v8::Persistent<T> const& p);
                                          ^
../node_modules/nan/nan_implementation_pre_12_inl.h:216:1: note: previous definition is
      here
NanNew(v8::Persistent<T> const& p) {
^
2 errors generated.
make: *** [Release/obj.target/addon/src/connection.o] Error 1
gyp ERR! build error
gyp ERR! stack Error: `make` failed with exit code: 2
gyp ERR! stack     at ChildProcess.onExit (/Users/rl/.nvm/v0.10.36/lib/node_modules/npm/node_modules/node-gyp/lib/build.js:269:23)
gyp ERR! stack     at ChildProcess.emit (events.js:98:17)
gyp ERR! stack     at Process.ChildProcess._handle.onexit (child_process.js:820:12)
gyp ERR! System Darwin 14.1.0
gyp ERR! command "node" "/Users/rl/.nvm/v0.10.36/lib/node_modules/npm/node_modules/node-gyp/bin/node-gyp.js" "rebuild"
gyp ERR! cwd /Users/rl/Sites/LumeFX/LumeFX-API/node_modules/pg-native/node_modules/libpq
gyp ERR! node -v v0.10.36
gyp ERR! node-gyp -v v1.0.3
gyp ERR! not ok

npm ERR! libpq@1.5.1 install: `node-gyp rebuild`
npm ERR! Exit status 1
npm ERR!
npm ERR! Failed at the libpq@1.5.1 install script.
npm ERR! This is most likely a problem with the libpq package,
npm ERR! not with npm itself.
npm ERR! Tell the author that this fails on your system:
npm ERR!     node-gyp rebuild
npm ERR! You can get their info via:
npm ERR!     npm owner ls libpq
npm ERR! There is likely additional logging output above.
npm ERR! System Darwin 14.1.0
npm ERR! command "/Users/rl/.nvm/v0.10.36/bin/node" "/Users/rl/.nvm/v0.10.36/bin/npm" "install"
npm ERR! cwd /Users/rl/Sites/LumeFX/LumeFX-API
npm ERR! node -v v0.10.36
npm ERR! npm -v 1.4.28
npm ERR! code ELIFECYCLE
npm ERR! not ok code 0
MCF commented 9 years ago

I'm seeing the same error on the latest version of OSX:

$ iojs -v
v1.6.4
$ uname -a
Darwin 14.3.0 Darwin Kernel Version 14.3.0: Mon Mar 23 11:59:05 PDT 2015; root:xnu-2782.20.48~5/RELEASE_X86_64 x86_64
$ gcc -v
Configured with: --prefix=/Applications/Xcode.app/Contents/Developer/usr --with-gxx-include-dir=/usr/include/c++/4.2.1
Apple LLVM version 6.1.0 (clang-602.0.49) (based on LLVM 3.6.0svn)
Target: x86_64-apple-darwin14.3.0
Thread model: posix
pcothenet commented 9 years ago

Same here.

both node-libpq and pg-native are failing at install since the latest OSX update this morning.

npm install libpq
|
> libpq@1.5.1 install /Users/pcothenet/Git/madkudu-common/node_modules/libpq
> node-gyp rebuild

  CXX(target) Release/obj.target/addon/src/connection.o
In file included from ../src/connection.cc:1:
In file included from ../src/addon.h:5:
In file included from ../node_modules/nan/nan.h:63:
../node_modules/nan/nan_new.h:207:43: error: inline declaration of 'NanNew' follows
      non-inline definition
template <typename T> inline v8::Local<T> NanNew(v8::Handle<T> h);
                                          ^
../node_modules/nan/nan_implementation_pre_12_inl.h:210:1: note: previous definition is here
NanNew(v8::Handle<T> h) {
^
In file included from ../src/connection.cc:1:
In file included from ../src/addon.h:5:
In file included from ../node_modules/nan/nan.h:63:
../node_modules/nan/nan_new.h:208:43: error: inline declaration of 'NanNew' follows
      non-inline definition
template <typename T> inline v8::Local<T> NanNew(v8::Persistent<T> const& p);
                                          ^
../node_modules/nan/nan_implementation_pre_12_inl.h:216:1: note: previous definition is here
NanNew(v8::Persistent<T> const& p) {
^
2 errors generated.
make: *** [Release/obj.target/addon/src/connection.o] Error 1
gyp ERR! build error 
gyp ERR! stack Error: `make` failed with exit code: 2
gyp ERR! stack     at ChildProcess.onExit (/Users/pcothenet/.nvm/v0.10.36/lib/node_modules/npm/node_modules/node-gyp/lib/build.js:267:23)
gyp ERR! stack     at ChildProcess.emit (events.js:98:17)
gyp ERR! stack     at Process.ChildProcess._handle.onexit (child_process.js:820:12)
gyp ERR! System Darwin 14.3.0
gyp ERR! command "node" "/Users/pcothenet/.nvm/v0.10.36/lib/node_modules/npm/node_modules/node-gyp/bin/node-gyp.js" "rebuild"
gyp ERR! cwd /Users/pcothenet/Git/madkudu-common/node_modules/libpq
gyp ERR! node -v v0.10.36
gyp ERR! node-gyp -v v1.0.2
gyp ERR! not ok 
npm ERR! Darwin 14.3.0
npm ERR! argv "node" "/Users/pcothenet/.nvm/v0.10.36/bin/npm" "install" "libpq"
npm ERR! node v0.10.36
npm ERR! npm  v2.5.0
npm ERR! code ELIFECYCLE

npm ERR! libpq@1.5.1 install: `node-gyp rebuild`
npm ERR! Exit status 1
npm ERR! 
npm ERR! Failed at the libpq@1.5.1 install script 'node-gyp rebuild'.
npm ERR! This is most likely a problem with the libpq package,
npm ERR! not with npm itself.
npm ERR! Tell the author that this fails on your system:
npm ERR!     node-gyp rebuild
npm ERR! You can get their info via:
npm ERR!     npm owner ls libpq
npm ERR! There is likely additional logging output above.

node 0.10.36. Same error with 0.12.2

MCF commented 9 years ago

The nan dependency is stale. libpq is requiring 1.5.0 which has the build problem seen above. The issue was noted here: https://github.com/rvagg/nan/issues/231 and fixed in nan 1.7.0.

MCF commented 9 years ago

There is already a pull request to fix this: https://github.com/brianc/node-libpq/pull/11

gregoralbrecht commented 9 years ago

Also seeing this on node 0.12.2 with gyp 1.0.3. I'm on windows though, if that matters at all.

brianc commented 9 years ago

This should be fixed now - sorry for the delay. I un-pinned the version of node-nan in package.json.

brianc commented 9 years ago

This should be fixed now - sorry for the delay. I un-pinned the version of node-nan in package.json.