search

brianc / node-libpq

Simple, low level native bindings to PostgreSQL's libpq from node.js
112 stars 42 forks source link

Update nan version #11

Closed claaslange closed 9 years ago

claaslange commented 9 years ago

Hey,

I had to update the nan version to 1.5.3 since nan 1.5.0 is broken, when using the version of clang that comes with Xcode 6.3.

Tests seem to run just fine after updating the version.

SupremeTechnopriest commented 9 years ago

:+1:

thomaschaaf commented 9 years ago

Please merge this pr as currently mac development is not possible because of this...

jakemmarsh commented 9 years ago

+1, unable to make any progress until this is merged. cc @brianc

MCF commented 9 years ago

As a development workaround you can install a patched version of the library manually, then carry on with npm install as normal. My fork has this problem patched so you could do the following to carry on developing:

npm install https://github.com/MCF/node-libpq
npm install

Once libpq is fixed and available via npmjs.com you would have to manually remove the module though, then reinstall libpq from the normal source. For example:

rm -r node_modules/libpq
npm install
jfsimon commented 9 years ago

@MFC thanks for this workaround! @brianc thanks for your awesome work with node/postgres! Any chance to see this PR merged quickly?

brianc commented 9 years ago

Sorry for missing this pull request y'all - I didn't get email alerts for this module in my inbox so I never saw it. I've fixed my emails to come to my inbox & I've updated the version of nan used here. Both node-libpq and node-pg-native should Install fine now & going forward they'll bump themselves up to more recent versions of node-nan as well.

jfsimon commented 9 years ago

@brianc thank you!

brianc commented 9 years ago

Thank you for being patient! Again - getting emails in my inbox now for issues on this repo - gmail was filtering them to the 'social' tab which I don't really check. I should be much more responsive now. :)

On Fri, May 1, 2015 at 11:08 AM, Jean-François Simon < notifications@github.com> wrote:

@brianc https://github.com/brianc thank you!

— Reply to this email directly or view it on GitHub https://github.com/brianc/node-libpq/pull/11#issuecomment-98151596.