search

brianc / node-libpq

Simple, low level native bindings to PostgreSQL's libpq from node.js
112 stars 42 forks source link

Failing to install in Win 8 #15

Closed gothammm closed 9 years ago

gothammm commented 9 years ago

gyp ERR! configure error gyp ERR! stack Error: gyp failed with exit code: 1 gyp ERR! stack at ChildProcess.onCpExit (G:\Program Files\nodejs\node_module s\npm\node_modules\node-gyp\lib\configure.js:343:16) gyp ERR! stack at ChildProcess.emit (events.js:98:17) gyp ERR! stack at Process.ChildProcess._handle.onexit (child_process.js:820: 12) gyp ERR! System Windows_NT 6.2.9200 gyp ERR! command "node" "G:\Program Files\nodejs\node_modules\npm\node_modu les\node-gyp\bin\node-gyp.js" "rebuild" gyp ERR! cwd D:\sharesliquid\omega.core\node_modules\libpq gyp ERR! node -v v0.10.36 gyp ERR! node-gyp -v v1.0.1 gyp ERR! not ok

npm ERR! libpq@1.6.1 install: node-gyp rebuild npm ERR! Exit status 1 npm ERR! npm ERR! Failed at the libpq@1.6.1 install script. npm ERR! This is most likely a problem with the libpq package, npm ERR! not with npm itself. npm ERR! Tell the author that this fails on your system: npm ERR! node-gyp rebuild npm ERR! You can get their info via: npm ERR! npm owner ls libpq npm ERR! There is likely additional logging output above. npm ERR! System Windows_NT 6.2.9200 npm ERR! command "G:\Program Files\nodejs\node.exe" "G:\Program Files\nod ejs\node_modules\npm\bin\npm-cli.js" "install" "libpq" npm ERR! cwd D:\sharesliquid\omega.core npm ERR! node -v v0.10.36 npm ERR! npm -v 1.4.28 npm ERR! code ELIFECYCLE npm ERR! not ok code 0

brianc commented 9 years ago

Did it use to work for you? Do you have pg_config in your path & available to node-gyp?

gothammm commented 9 years ago

Yes it was working fine for me. Then it failed in Mac OS X. After the recent fix on pg-native for Mac OS it started failing in windows On 4 May 2015 00:11, "Brian C" notifications@github.com wrote:

Did it use to work for you? Do you have pg_config in your path & available to node-gyp?

— Reply to this email directly or view it on GitHub https://github.com/brianc/node-libpq/issues/15#issuecomment-98520461.

brianc commented 9 years ago

I'm pretty sure this commit is the offending one:

https://github.com/brianc/node-libpq/commit/d658d489d0b87c4e2e432fb880d1457e987324f6

Can you look at that gypfile config in there and see if there are any obvious errors? I don't have access to a windows machine. If all else fails I can manually undo the changes to the windows version of the config since it seemed to work just fine previously.

brianc commented 9 years ago

@peek4y can you see if this PR fixes your install issue on windows? https://github.com/brianc/node-libpq/pull/20

gothammm commented 9 years ago

@brianc Nope that did not work :( still can't install.

brianc commented 9 years ago

Sorry for the dumb question but did you clone this repo & attempt to build the branch containing the PR? I haven't pushed the PR changes to npm yet so installing from NPM is still gonna fail.

brianc commented 9 years ago

I'm gonna push that fix to npm right now anyways since it did fix someone's windows issue.

brianc commented 9 years ago

npm install libpq@1.6.4 should have the fix now if you wanna try from npm

gothammm commented 9 years ago

Nope, I didn't clone. Will check again now.

gothammm commented 9 years ago

YAY! Works perfectly. Thanks @brianc

brianc commented 9 years ago

Awesome! I'm happy it fixed it!! :dancer: Thanks so much for testing it - sorry I don't have access to a well configured windows env.

gothammm commented 9 years ago

:+1: No problem, and thanks again.