search

brianc / node-libpq

Simple, low level native bindings to PostgreSQL's libpq from node.js
112 stars 42 forks source link

Update nan #18

Closed BridgeAR closed 9 years ago

BridgeAR commented 9 years ago

iojs 2.0 needs an up to date nan to work properly

This is needed for sequelize with pg-native active to work

brianc commented 9 years ago

Understandable. Question though - does pg-native not pull down the most recent version of node-libpq? And then does node-libpq not also pull down the most recent minor version of node-nan as well? I thought I had all the semver versions pinned flexibly enough already.

BridgeAR commented 9 years ago

This depends on the system it's running on. At least travis seems to use the oldest version instead of the newest. Other than that it should be updated as >=1.5.0 <2.0.0

brianc commented 9 years ago

Cool, I definitely don't see this hurting anything. :smile: I appreciate you taking the time to put this in. I'll merge this & bump a minor version here so hopefully the dependency chain starts picking up the higher nan requirements.