search

brianc / node-libpq

Simple, low level native bindings to PostgreSQL's libpq from node.js
112 stars 42 forks source link

Update to NAN 2 #25

Closed kkoopa closed 9 years ago

ruimarinho commented 9 years ago

Working fine on iojs v3.0.0 (OSX, El Cap). Thanks!

kkoopa commented 9 years ago

Note that I had to disable one test and tweak another. Don't know what the proper fixes are.

brianc commented 9 years ago

Dang I really appreciate the effort you put into this. I don't have time to totally dive into it yet & can't merge it until we figure out how to get those tests back to a passing status, but it's on my radar to get working completely. This is a huge amount of work & it's greatly appreciated...i'll try to start in on it this weekend.

fundon commented 9 years ago

@kkoopa :+1:

@brianc Nice! pg-native also needs to upgrade libpg.

fundon commented 9 years ago

@brianc Could you merge this, please?

brianc commented 9 years ago

@fundon I can't merge this until all the tests are passing - I haven't had time to fix it.

Qard commented 9 years ago

With node 4.0.0 about to drop, it'd be good to get this working soon.

bkw commented 9 years ago

Regarding the commented-out test : I commented it in and it passes.

iojs 3.3.0, OSX 10.10.5, postgres 9.4.4

bkw commented 9 years ago

I created a branch on top of @kkoopa 's at https://github.com/bkw/node-libpq/tree/nan2 that puts the tests back to normal and fixes the copy-in behaviour. Probably somebody should clean up bkw/node-libpq@a647786 but you'll get the idea. Thanks to @kkoopa for all the hard work!