build under current npm fails in many regards

trailsandtribulations commented 9 years ago

have been using node-libpq, but now can no longer build with npm. seems to be two sorts of errors:

../node_modules/nan/nan.h:324:27: error: redefinition of ‘template v8::Local Nan::imp::NanEnsureHandleOrPersistent(const v8::Local&)’
   NAN_INLINE v8::Local NanEnsureHandleOrPersistent(const v8::Local &val) {

and

../node_modules/nan/nan.h: In function ‘v8::Local NanNewBufferHandle(char*, size_t, int)’:
../node_modules/nan/nan.h:761:50: error: ‘callback’ was not declared in this scope
         v8::Isolate::GetCurrent(), data, length, callback, hint);
                                                  ^
../node_modules/nan/nan.h:761:60: error: ‘hint’ was not declared in this scope

bkw commented 9 years ago

This should be fixed once #31 is merged.

brianc commented 9 years ago

Should be fixed thanks to @bkw - can you test again @trailsandtribulations?

trailsandtribulations commented 9 years ago

will test and reply

On Tue, Sep 8, 2015 at 11:52 PM, Brian C notifications@github.com wrote:

Should be fixed thanks to @bkw https://github.com/bkw - can you test again @trailsandtribulations https://github.com/trailsandtribulations?

— Reply to this email directly or view it on GitHub https://github.com/brianc/node-libpq/issues/26#issuecomment-138631702.

trailsandtribulations commented 9 years ago

compiles!

if functional problems are found, which I doubt, will post new issue.

brianc / node-libpq

build under current npm fails in many regards #26