Update to NAN 2 - fixed tests

brianc / node-libpq

Simple, low level native bindings to PostgreSQL's libpq from node.js

112 stars 42 forks source link

Update to NAN 2 - fixed tests #31

Closed bkw closed 9 years ago

bkw commented 9 years ago

Son of #25. This is just to allow for easier merging. All Credits go to @kkoopa.

bkw commented 9 years ago

I tested this against pg-native and there seems to be a problem with pg.cancel(). Will investigate.

bkw commented 9 years ago

I fixed cancel() to return the error in case struct allocation fails. This behaviour was inadvertently changed to throwing in the original patch. Now the pg-native tests using this version of libpq pass.

kkoopa commented 9 years ago

Cool. Good that it got fixed.

fundon commented 9 years ago

👍🚀

brianc commented 9 years ago

@bkw thank you a bunch for fixing this! I'll get this merged & a new version pushed up shortly.