search

brianc / node-libpq

Simple, low level native bindings to PostgreSQL's libpq from node.js
112 stars 42 forks source link

Update nan #39

Closed Qard closed 8 years ago

Qard commented 8 years ago

Node v6 is incoming, and nan 2.2.x is needed to support it.

Qard commented 8 years ago

Node v6 is out now, and libpq currently does not build on it.

brianc commented 8 years ago

Hey @Qard - I really appreciate you putting this together. One small request: can you add v6 to the .travis.yml file? That way we can be sure this fixes for node v6 and also make sure we never break compatibility in the future. After that I'll happily merge!

Qard commented 8 years ago

Looks like it's having issues due to https://github.com/nodejs/node/pull/6228, actually. I think it'll have to wait for another version of nan.

ruimarinho commented 8 years ago

The fix has been merged (https://github.com/nodejs/nan/commit/00dacf0a4b86027415867fa7f1059acc499dcece) and published as nan@2.3.0.

Qard commented 8 years ago

Closing, as this appears to be fixed by #41. Thanks!

brianc commented 8 years ago

thank YOU

On Fri, Apr 29, 2016 at 4:10 PM, Stephen Belanger notifications@github.com wrote:

Closed #39 https://github.com/brianc/node-libpq/pull/39.

— You are receiving this because you commented. Reply to this email directly or view it on GitHub https://github.com/brianc/node-libpq/pull/39#event-646224951