brianc / node-libpq

Simple, low level native bindings to PostgreSQL's libpq from node.js
111 stars 41 forks source link

getting error as of 1.8.6 #53

Closed scamden closed 7 years ago

scamden commented 7 years ago

> node-gyp rebuild

  CXX(target) Release/obj.target/addon/src/connection.o
clang: error: invalid deployment target for -stdlib=libc++ (requires OS X 10.7 or later)```
scamden commented 7 years ago

im on mac sierra 10.12.3 fyi

scamden commented 7 years ago

@brianc not sure who to ping here but this is a pretty major problem in a patch bump, so it's breaking all over the place for me, and probably a lot of other mac users

elhoyos commented 7 years ago

I have the same error when using node@4.4.7, however when using node@6.9.5 it builds ok for me.

I recently installed XCode 8.3 with its Command Line Tools in 10.12.3. Can't tell if this was the cause of the problem.

49 seems highly related.

brianc commented 7 years ago

Hmm - it's building and passing in travis @ 1.4.x and 1.6.x - I'm 100% open to pull requests to fix build issues related to OS X + xcode + 1.4.x node and would greatly appreciate them! Feel free to ping me if you figure out what's wrong!

scamden commented 7 years ago

verified the newest patch installs properly. thanks for publishin so quickly.