brianc / node-libpq

Simple, low level native bindings to PostgreSQL's libpq from node.js
111 stars 41 forks source link

Fixed building against libc++ when osx min target < 10.7 #54

Closed elhoyos closed 7 years ago

elhoyos commented 7 years ago

Solves #53 when trying to build against libc++ on MACOSX_DEPLOYMENT_TARGET < 10.7.

Older versions of node use by default a MACOSX_DEPLOYMENT_TARGET incompatible with libc++. Compare v4.4.7 & v6.9.5.

This commit also moves these conditions into its own section for os x.

brianc commented 7 years ago

Thanks a lot @elhoyos!! I'll push a new patch out to npm right away. :)