brianc / node-libpq

Simple, low level native bindings to PostgreSQL's libpq from node.js
111 stars 41 forks source link

Error finding libs on windows #66

Open miraries opened 5 years ago

miraries commented 5 years ago

The following error comes up when installing:

e:\user\project\test\node-pg-native\node_modules\libpq\src\addon.h(5): fatal error C1083: Cannot open include file: 'libpq-fe.h': No such file or directory (compiling source file ..\src\connection.cc) [E:\user\project\test\node-pg-native\node_modules\libpq\build\addon.vcxproj]

After reading the input format reference for gyp I fixed it by changing the include_dirs in bindings from <!@(<(pgconfig) --includedir) to <!(<(pgconfig) --includedir)

I'm not sure if this should be changed, can there be multiple include directories for postgres? Anyway, with the former the compiler command has: /IE:\Program /I..\Files\PostgreSQL\10\include and with the change: /I"E:\Program Files\PostgreSQL\10\include"

Just posting if someone runs into this. Took me some time to get familiar with gyp but the main takeway, as it seems to be with other projects: no spaces in paths