search

brianc / node-pg-cursor

Query cursor extension for node-postgres
78 stars 30 forks source link

fix for new version of pg #50

Closed yocontra closed 4 years ago

yocontra commented 5 years ago

The last minor release broke this module, this PR should fix it.

brianc commented 5 years ago

Thanks for putting this together! Can you bump the version in package.json to pg: '7.x'? That way the tests will pass. Thanks!

yocontra commented 5 years ago

@brianc Updated the deps in package.json. As an aside - the tests fail on latest node versions, and travis is using some pretty old stuff. Core stream behavior has changed since node 8 so something will probably need to be updated in a major breaking release + dropping support for older versions of node.

yocontra commented 5 years ago

@brianc Ping ^

brianc commented 5 years ago

oof tests are failing on every version of node. I'll update to newer versions of node & figure out why they're failing. Probably wont be able to get to this until tomorrow or thursday

yocontra commented 5 years ago

@brianc Let me know if you want me to look into it + update the travis config as a part of this PR.

brianc commented 4 years ago

Closed with #57

yocontra commented 4 years ago

@brianc Sweet, can you publish the changes to NPM?

brianc commented 4 years ago

yup will do today!

On Sun, Oct 27, 2019 at 7:07 PM contra notifications@github.com wrote:

@brianc https://github.com/brianc Can you publish the changes?

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/brianc/node-pg-cursor/pull/50?email_source=notifications&email_token=AAAMHIOA2DWSQZPQSGSYELLQQYUKLA5CNFSM4HG5JTVKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOECLLYTA#issuecomment-546749516, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAAMHILQAJ24TWTEALDCHIDQQYUKLANCNFSM4HG5JTVA .