search

brianc / node-pg-pool

A connection pool for node-postgres
MIT License
180 stars 64 forks source link

Upgrade to generic-pool v3 #29

Closed sandfox closed 7 years ago

sandfox commented 8 years ago

It's still not quite finished, but the API changes are all done and pending any critical bugs should be final. The 2 big changes are

Minor changes include renaming/removing some config options and constructor args.

Before I get started on the PR for this, I just wanted to check that your ok with doing this.

EDIT -- Also - totally up for any suggestions of things you'd like to see in it or questions about the changes or anything you think is completely daft, or if you'd like me to explain anything!

brianc commented 8 years ago

Most definitely!

On Sunday, September 18, 2016, James Butler notifications@github.com wrote:

It's still not quite finished, but the API changes are all done and pending any critical bugs should be final. The big change is the move over to using promises instead of callbacks (except for the "pooled" function which I still haven't quite worked out yet) Minor changes include renaming/removing some config options and constructor args.

Before I get started on the PR for this, I just wanted to check that your ok with doing this.

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/brianc/node-pg-pool/issues/29, or mute the thread https://github.com/notifications/unsubscribe-auth/AADDoRmsCpKmNXlPQ7w2wxlQ3d2WiZeHks5qrQ8QgaJpZM4J_3P8 .

abenhamdine commented 7 years ago

Is the v3 to support acquire time out ? If I'm correct, this feature is needed to allow to have an error in case of time out with pg.connect.

sandfox commented 7 years ago

@abenhamdine yep, the acquire call timeout support (and ability to more easily add timeouts for other operations) is in the v3 branch. It also isolates factory errors from acquire calls so the two are no longer linked/locked 1:1.

abenhamdine commented 7 years ago

ah fabulous, can't wait 💃 😄

sandfox commented 7 years ago

ok, finally published the new version after some serious detours. (and already have bugs to deal with!) @brianc - whats the baseline version of nodejs pg-pool is designed to work with? At the moment, generic-pool v3 requires node v4 because it uses Promises, Sets, Maps and some other es6-isms. With some work it's probably possible to make some version of generic pool (or a module that wraps it) that could shim out those requirements with some < node 4 compatible equivalents.

Thoughts?

brianc commented 7 years ago

Generic pool has been removed as a dependency. in pg-pool@2.0