1.6.0 broke backward compatibility by returning undefined on connect()

brianc / node-pg-pool

A connection pool for node-postgres

MIT License

180 stars 64 forks source link

1.6.0 broke backward compatibility by returning undefined on connect() #38

Closed diegoperini closed 7 years ago

charmander commented 7 years ago

Yes, I mentioned that it would, but it was published as a minor version – maybe because it wasn’t intentional to begin with. Anyway, use 1.4.x (not 1.5.x) if you need to for some reason.

brianc commented 7 years ago

My apologies for that. Out of curiosity, what did it return before?

charmander commented 7 years ago

A promise, even when a callback was provided, causing #24. Since the behaviour wasn’t documented and there was never a use case for it, though, this isn’t really a problem.

brianc commented 7 years ago

Ohh okay cool - well this is fixed in 2.0! :dancer:

brianc commented 7 years ago

My appologies for breaking backwards compat - I'll try to keep an eye out for that in the future.