search

brianc / node-pg-pool

A connection pool for node-postgres
MIT License
180 stars 64 forks source link

pg dependency #45

Closed spudly closed 7 years ago

spudly commented 7 years ago

pg-pool requires pg but does not include it in either dependencies or peerDependencies

brianc commented 7 years ago

Yah it doesn't require any specific version of pg so it's up to you to install whichever version of pg you'd like & then pg-pool. I put that in the readme. I have a lot of existing projects with different versions of pg installed and want both pg & pg-pool at the top level in their node_modules. I'm open to changing it but I prefer to install them each myself.

charmander commented 7 years ago

{"peerDependencies": {"pg": "*"}} might satisfy everyone, then?

spudly commented 7 years ago

@charmander, yes that's what it should be