Closed bendrucker closed 4 years ago
Breaking changes also worth considering for a major release:
integer types as BigInt
instead of string for much better type safety (requires Node 10, so maybe not if this is targeted at Node 8) (#78)
no Date
conversion for date
and (maybe?) timestamp without time zone
(#50, #81)
removal of lib/arrayParser.js
I think we should just get a major release out and evaluate dates and big ints for a later major. We haven't been doing many of these releases. Removing lib/arrayParser.js
seems easy/uncontroversial.
@brianc Thoughts on doing a major release for Node 8 and then doing a future major for Node 12 that incorporates BigInt + Date changes?
Thoughts on doing a major release for Node 8 and then doing a future major for Node 12 that incorporates BigInt + Date changes?
Yeah I'm down with that. You want a major bump in node-posgres core as well right? I can sweep in a couple other breaking changes we wanted to make too.
You want a major bump in node-posgres core as well right?
Yup, major bump here, and then a major bump in node-postgres updating the dep.
Merging #105 into master will increase coverage by
0.6%
. The diff coverage isn/a
.
@@ Coverage Diff @@
## master #105 +/- ##
=========================================
+ Coverage 88.01% 88.62% +0.6%
=========================================
Files 5 4 -1
Lines 217 211 -6
=========================================
- Hits 191 187 -4
+ Misses 26 24 -2
Impacted Files | Coverage Δ | |
---|---|---|
index.js | 75% <ø> (-2.28%) |
:arrow_down: |
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact)
,ø = not affected
,? = missing data
Powered by Codecov. Last update 96d238f...0d2ea80. Read the comment docs.
Finally took the time to merge this and release 3.0 to npm. Happy to take on further breaking changes in 4.0 which might be node 12+ assuming it comes early 2020.
@brianc Do you need any help landing other changes to node-postgres? If not I can just open the PR bumping the pg-types dep and setting engines.node
.
What is the correct way to parse the array now?
This broke https://github.com/gajus/slonik/issues/182
This is how I fixed it https://github.com/gajus/slonik/commit/042669dab03421e18e8dda270c92a4089cbdedd7, but not sure if that was the expected way.
@gajus That works, yes. You can also write parseArray(arrayValue, typeParser.parse)
.
This would require a major version bump, which I think we should be doing anyway as numeric/binary oriented changes have been piling up in master. @brianc are you ok with going ahead with a major release of node-postgres as well? Node 4's EOL was about 1.5 years ago. 8's is coming up (December).
Closes #104