search

brianc / node-pg-types

Type parsing for node-postgres
270 stars 55 forks source link

update postgres-array to v2 #76

Closed bendrucker closed 5 years ago

bendrucker commented 6 years ago

Adds support for handling array dimensions (by discarding) in https://github.com/bendrucker/postgres-array/pull/6

I've added an engine here to match pg and postgres-array and updated Travis to match. This should be published as a major version to be safe. Then pg can just get a patch update that makes the update to types.

@brianc I don't have publish rights on this package (or pg), let me know if you'd rather add me or publish yourself

bendrucker commented 5 years ago

Hey @brianc, just wanted to check on this one if you have a sec

bendrucker commented 5 years ago

Do you use 2FA for npm publishing? I'd like to make sure we all have that enabled to protect our users.

Absolutely, I have 2FA on as a user. I think somewhat recently npm also added the following:

That means even a user must configure/pass 2FA even if it's not on at their account level.

https://docs.npmjs.com/requiring-2fa-for-package-publishing-and-settings-modification

brianc commented 5 years ago

awesomeness! whats yer npm username - will add you right myeah.

bendrucker commented 5 years ago

bendrucker

brianc commented 5 years ago

added you!

bendrucker commented 5 years ago

Published as 2.0, will send a PR to pg

brianc commented 5 years ago

:dancer:

On Tue, Jan 8, 2019 at 3:16 PM Ben Drucker notifications@github.com wrote:

Published as 2.0, will send a PR to pg

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/brianc/node-pg-types/pull/76#issuecomment-452454415, or mute the thread https://github.com/notifications/unsubscribe-auth/AADDoSCmG5qDB95FuVTG8BDpUDH6oGIfks5vBQrCgaJpZM4Xz5tx .