search

brianc / node-postgres-docs

Documentation for node-postgres
https://node-postgres.com
MIT License
98 stars 94 forks source link

Update 1-connecting.mdx #126

Closed JoelVenable closed 3 years ago

JoelVenable commented 3 years ago

Documentation should mention supported feature.

https://github.com/brianc/node-postgres/issues/2513

netlify[bot] commented 3 years ago

Hey! A preview of the changes is deployed on netlify to take a look at! :)

Built with commit 80f61e041538ff0922e217f60ea595ec1eeb6a1a

https://deploy-preview-126--hopeful-clarke-f36d36.netlify.app

sehrope commented 3 years ago

Replace the double spaces at sentence end with single spaces and remove the extra newlines at the top/bottom of the sample code block to match the rest of the README.

Otherwise, looks good to me. :+1:

charmander commented 3 years ago

Is it possible to make this a more realistic example? It doesn’t have to be complete/runnable.

JoelVenable commented 3 years ago

Thanks for your feedback! Sugggestions implemented in the update.

charmander commented 3 years ago

Thank you!

sehrope commented 3 years ago

Yes that's much nicer.