This PR adds types that guide user from sql.define to table objects, and type-helped use of those. Related issue is #351
Definition file is very useful, yet isn't 100% incomplete, as only sql.define is added to types, while there are other things in the module. SQL is vast, so is node-sql (superb job :+1: ), hence, 100% coverage with types is a task. But I already use these types in production. Can we say that 80% is already here?
Definitions can be a place for comments that people will read, thanks to mature TS's tooling (VSCode, etc.). So, definitions can be added. It can be done gradually.
brianc
commented
7 years ago
This PR adds types that guide user from
sql.defineto table objects, and type-helped use of those. Related issue is #351Definition file is very useful, yet isn't 100% incomplete, as only
sql.defineis added to types, while there are other things in the module. SQL is vast, so is node-sql (superb job :+1: ), hence, 100% coverage with types is a task. But I already use these types in production. Can we say that 80% is already here?Definitions can be a place for comments that people will read, thanks to mature TS's tooling (VSCode, etc.). So, definitions can be added. It can be done gradually.