Add FULL and RIGHT outer joins for all DBs.

brianc / node-sql

SQL generation for node.js

MIT License

1.05k stars 191 forks source link

Add FULL and RIGHT outer joins for all DBs. #374

Closed Carl-Foster closed 4 years ago

Carl-Foster commented 7 years ago

There lacked the ability to join with other types of joins.

I've added in FULL OUTER and RIGHT to enable a more complete set of functionality. It uses the functions rightJoin() and fullOuterJoin() to access this ability.

When the dialect is SQLite, it ensures to throw an Error since it's not supported on that platform.

Carl-Foster commented 6 years ago

@brianc I think this is fine, but just bumping to see if you're interested in merging it.

Carl-Foster commented 6 years ago

@brianc I don't require this functionality anymore, but I think this would be somewhat useful to others. Is this okay to merge?