TableDefinition.schema should not be required

brianc / node-sql

SQL generation for node.js

MIT License

1.05k stars 191 forks source link

TableDefinition.schema should not be required #376

Closed dylanmcdiarmid closed 7 years ago

dylanmcdiarmid commented 7 years ago

From a quick search, it seems like it is only used by oracle. Regardless, it isn't used in the examples given on the homepage, so it's confusing to have it required in the definition.

dylanmcdiarmid commented 7 years ago

It looks like the TS definition has more problems than just this (mapped types aren't working properly in my use case). I'll close this for now, easy enough to add in when/if types get another look.