Update TableDefinition type be compatible with shorthand usage - Githubissues

brianc / node-sql

SQL generation for node.js

MIT License

1.05k stars 191 forks source link

Update TableDefinition type be compatible with shorthand usage #406

Closed bunsenmcdubbs closed 4 years ago

bunsenmcdubbs commented 5 years ago

Previous typedef for TableDefinition was not compatible with common document usage/examples

import * as sql from 'sql';

const user = sql.define({
  name: 'user',
  columns: ['id', 'name', 'email', 'lastLogin'] // string[] not compatible with {[CName in keyof Row]: ColumnDefinition<CName, Row[CName]>}; 
});

schema field is optional
Adding string[] as an option for the column field
Additionally, Typescript 2.9 added number and symbol as part of keyof so we need to Extract only the string keys from Row. https://www.typescriptlang.org/docs/handbook/release-notes/typescript-2-9.html

karianpour commented 5 years ago

I have the same issue, is there any workaround available?