Type change to allow typescript > 2.7.2

brianc / node-sql

SQL generation for node.js

MIT License

1.05k stars 191 forks source link

Type change to allow typescript > 2.7.2 #421

Closed 3n-mb closed 1 week ago

3n-mb commented 2 years ago

Typescript versions greater than 2.7.2, keyof produces string|number|symbol, failing on line 40.

One fix is have on lines 19 and 22 Name extends string|number|symbol instead of Name extends string. But this work around may feel a bit not intuitive.

Change directly on line 40, & with string does the trick of fitting types.

r-miladi commented 2 weeks ago

Might it be possible to get this PR accepted?