search

briancavalier / creed

Sophisticated and functionally-minded async with advanced features: coroutines, promises, ES2015 iterables, fantasy-land
https://briancavalier.github.io/creed
MIT License
273 stars 20 forks source link

Update eslint-plugin-node to the latest version 🚀 #153

Closed greenkeeper[bot] closed 7 years ago

greenkeeper[bot] commented 7 years ago

Version 5.0.0 of eslint-plugin-node just got published.

Dependency eslint-plugin-node
Current Version 4.2.2
Type devDependency

The version 5.0.0 is not covered by your current version range.

Without accepting this pull request your project will work just like it did before. There might be a bunch of new features, fixes and perf improvements that the maintainers worked on for you though.

I recommend you look into these changes and try to get onto the latest version of eslint-plugin-node. Given that you have a decent test suite, a passing build is a strong indicator that you can take advantage of these changes by merging the proposed change into your project. Otherwise this branch is a great starting point for you to work on the update.

Release Notes v5.0.0

Notable changes are 2:

  1. Node.js 8 support were added.
  2. The check of extraneous packages were separated from no-unpublish-import rule and no-unpublish-require rule.

Breaking changes

  • 3387336 updated no-unsupported-features rule for Node.js 8.
    • Node.js 8 newly supports trailing commas in functions.
    • This rule went to use 4.0.0 if you don't specify the node version. It has been 0.10.0 before.
    • This rule went to warn SharedArrayBuffer and Atomics. Currently any versions of Node.js don't support those variables.
  • 0e487f9 updated no-deprecated-api rule for Node.js 8.
    • Node.js 8 deprecated vm.runInDebugContext().
    • Additionally, Node.js 8 made the official page about deprecated APIs. I realized this rule had been lacking the check of some deprecated APIs. I added those.
  • d4e6bc4 removed the check about extraneous packages from no-unpublish-import rule and no-unpublish-require rule.

New rules

  • a75c638 added 2 new rules, no-extraneous-import and no-extraneous-require. Those rules report require() expressions or import declarations if those import extraneous packages.
    • Those behavior were extracted from no-unpublished-require and no-unpublished-import.

Bug fixes

  • deb4f55 fixed a bug of no-unsupported-features about semver comparison. (#78)
Commits

The new version differs by 14 commits.

  • 5634718 5.0.0
  • aea8e82 Chore: remove deprecated rule's tests
  • 118a1de Chore: add note about require("punycode/") (fixes #72)
  • cf36e6d Chore: improve auto-generation script
  • d4e6bc4 Breaking: remove extraneous check from no-unpublish-* (fixes #71)
  • a75c638 New: no-extraneous-* rules (refs #71)
  • deb4f55 Fix: no-unsupported-features goes wrong on >=7.10.0 (fixes #78)
  • 0e487f9 Breaking: update no-deprecated-api (fixes #80)
  • 3387336 Breaking: update no-unsupported-features rule (fixes #79)
  • fdd7877 Chore: add Node.js 8 to CI
  • fa95be2 Chore: add cache to exists()
  • ffc7fcb Chore: refactor with classes.
  • 8f00ebb Chore: remove object-assign from dependencies
  • 734d2e7 Chore: upgrade dependencies

See the full diff

Not sure how things should work exactly? There is a collection of [frequently asked questions](https://greenkeeper.io/faq.html) and of course you may always [ask my humans](https://github.com/greenkeeperio/greenkeeper/issues/new).

Your Greenkeeper Bot :palm_tree:

coveralls commented 7 years ago

Coverage Status

Coverage remained the same at 100.0% when pulling caccf664582c04790249ac8a1571b637c946d616 on greenkeeper/eslint-plugin-node-5.0.0 into 82e271ad9cfa81b6645b38cb1d8f551fac1b1826 on master.