search

briancavalier / creed

Sophisticated and functionally-minded async with advanced features: coroutines, promises, ES2015 iterables, fantasy-land
https://briancavalier.github.io/creed
MIT License
273 stars 20 forks source link

Simplify and improve trace output #173

Closed briancavalier closed 6 years ago

briancavalier commented 6 years ago

Trace eliding and naming was not working well in Node 6-9, due to what appears to be some changes in how captureStackTrace generates the first line of the trace. Also, internal file names seem to change between every Node release, so trying to elide them by listing a few names isn't really a sustainable solution. It looks like the internal filenames are always like just_a_filename.js, with no preceding path (and specifically, no slashes). So, this switches to a regex that filters out lines that point at just_a_filename.js.

coveralls commented 6 years ago

Coverage Status

Coverage remained the same at 100.0% when pulling 6acacacec3ba890d42c9052618e9ebfb68e4582b on simplify-trace into 7276de4da85a2774c958be0e93dea984449b2b0f on master.

coveralls commented 6 years ago

Coverage Status

Coverage remained the same at 100.0% when pulling 6acacacec3ba890d42c9052618e9ebfb68e4582b on simplify-trace into 7276de4da85a2774c958be0e93dea984449b2b0f on master.

coveralls commented 6 years ago

Coverage Status

Coverage remained the same at 100.0% when pulling 1b681c82f3a3e4d35fe94afe31812999e1ceaf35 on simplify-trace into 7276de4da85a2774c958be0e93dea984449b2b0f on master.