search

briancavalier / creed

Sophisticated and functionally-minded async with advanced features: coroutines, promises, ES2015 iterables, fantasy-land
https://briancavalier.github.io/creed
MIT License
273 stars 20 forks source link

fix(readme): change to babel-node-cli #176

Closed dmitriz closed 6 years ago

dmitriz commented 6 years ago

Update the package name, the old one throws the warning:

You tried to install babel-node. This is not babel-node 🚫          │
|               You should npm install -g babel-cli instead 💁 .               │
|    I took this module to prevent somebody from pushing malicious code. 🕵    │
|                    Be careful out there,
coveralls commented 6 years ago

Coverage Status

Coverage remained the same at 100.0% when pulling b1cef91dc73a52f50c7951ad46bf5cb43ec5a754 on dmitriz:typo into ada802ae0530bf4db3a5d8bb160a085fbe363e46 on briancavalier:master.

dmitriz commented 6 years ago

Note that babel-node still throws its favourite message:

> Error: Couldn't find preset "es2015" ...

where the plain node instead seems to work just fine with Node 8 at least, so maybe no need to use babel here at all?

dmitriz commented 6 years ago

@briancavalier You are totally right, sorry, it is babel-cli but the command is still babel-node, and it still wouldn't work out of the box.

I have now changed to the good ol node and all the examples work fine, so perhaps no need to use babel at all?

briancavalier commented 6 years ago

You're right! That's great news. Seems like we don't need babel for the example 👍