search

briancavalier / creed

Sophisticated and functionally-minded async with advanced features: coroutines, promises, ES2015 iterables, fantasy-land
https://briancavalier.github.io/creed
MIT License
273 stars 20 forks source link

Add or(), deprecate concat() #89

Closed briancavalier closed 7 years ago

briancavalier commented 7 years ago

This is a step toward Fantasy Land 2.1. The idea is to use a different name for the operation currently called concat, since that operation is a race, and as such, is more like Alt than Semigroup. In 2.0, we can implement a new concat that concats two values in the future, rather than racing. Step 1 in that plan is to provide a new name in the public API for concat. I picked or. Fantasy Land calls this operation alt, so that may also be a reasonable choice--although I like or better for a public API that users will call directly.

Todo

coveralls commented 7 years ago

Coverage Status

Coverage remained the same at 100.0% when pulling e34cc7939a5dc21b21ea4b0c73690c3c6b65e1fc on add-or-deprecate-concat into 4472a7b4ba28115cc8046d3e77a8953c42dbce83 on master.

davidchase commented 7 years ago

👍 for or makes sense even if people dont get the FL concepts and concat of future values

coveralls commented 7 years ago

Coverage Status

Coverage remained the same at 100.0% when pulling d35b1c8a4458d8daac2c55eb045918bc1168c53b on add-or-deprecate-concat into 4472a7b4ba28115cc8046d3e77a8953c42dbce83 on master.