search

brianchance / MvvmCross-UserInteraction

MvvmCross plugin for interacting with the user from a view model
MIT License
43 stars 44 forks source link

#8 Added Windows Phone and Windows Store support #11

Closed ChristianRuiz closed 10 years ago

brianchance commented 10 years ago

Christian, I have been out of town. Everything looks good, but I really have no way to test your changes. I can live with that for now if you can support it, not sure how to handle updates going forward...

Can you modify to include changes for nuget? I think you can follow the pattern for the MvvmCross messenger - https://github.com/MvvmCross/MvvmCross/blob/v3.1/nuspec/MvvmCross.HotTuna.Plugin.Messenger.3.0.1.nuspec

ChristianRuiz commented 10 years ago

Hi Brian,

I've added another commit with the nuget metadata created, you could use the NuGet Package Explorer to open it and generate the package, or I can send you the generated package by email if you provide one (that way you won't need to compile the WP and WinStore dlls):

http://npe.codeplex.com/

brianchance commented 10 years ago

I should be able to use the binaries you directed to lib.

ChristianRuiz commented 10 years ago

Sure, when you said that you got no way to test them, I've imagined that you work on a Mac, sorry! Just compile the project on release, open the .nuspec file with the NuGet Package Explorer and click on "Save" to create the .nupkg package. Once you got it, just go to http://www.nuget.org/ login and upload the package.

brianchance commented 10 years ago

I do work on a Mac, I copy the lib folder across to my window machine for nuget. I do not have Xamarin licenses for windows, so I cannot do a unified compile.

ChristianRuiz commented 10 years ago

Ok, if you got any trouble I'll be happy to help.

brianchance commented 10 years ago

Just noticed you added nuget, I had a nuspec folder already. I will try to merge the two.

brianchance commented 10 years ago

Looks like I will need the output of the bin\Release\WindowsPhone and bin\Release\WindowsStore since I cannot compile.

ChristianRuiz commented 10 years ago

Sorry about the folder, here you can download the nupkg already created and the dlls for Windows Phone and Windows Store: https://onedrive.live.com/redir?resid=DB7A3D81E5CED347!794&authkey=!AE9d6uqtyDJ3HKs&ithint=folder%2c.nupkg

brianchance commented 10 years ago

I added your files to my existing nuget package. I think going forward, if you could commit the output from the bin\Release folder for the two projects it should go smoothly.

Thanks for the addition.

ChristianRuiz commented 10 years ago

You want me to commit the dlls to the repo? Won't it give us merge problems in future commits?

brianchance commented 10 years ago

If you could do at least the bin\Release\WindowsStore/WindowsPhone that would be good. I will add the Droid and Touch dlls. I think there is an entry in .gitignore for bin, we can change it to ignore bin\Debug.

As for merging, should not be an issue (the lib folder has binaries now).