search

brianchirls / proto-loader

Protocol Buffer loader module for webpack
27 stars 18 forks source link

Release on npm #3

Closed sindrenm closed 8 years ago

sindrenm commented 9 years ago

This package doesn't seem to be available on npm, or at least I cannot find it under the name proto-loader.

brianchirls commented 8 years ago

Hey, thanks for filing these. For some reason, I didn't get a notification that anyone had file issues or pull requests. I'll take a look this week.

vjpr commented 8 years ago

+1

brianchirls commented 8 years ago

Package name is fixed.

Would you guys mind sharing your opinions on #4? That would break any existing code, so I'd like to get that resolved before releasing on npm. Thanks.

watsoncj commented 8 years ago

I'm all for the usage simplification. What do you think of publishing the current version to npm?

Any breaking changes should be published under a new major version.

sindrenm commented 8 years ago

Considering project hasn't reached 1.0.0 yet, I wouldn't be too concerned about publishing a new major version, since it's per the spec still in a pre-release stage. I would instead keep increasing the minor version until you feel it's stable and ready for release.

quasor commented 8 years ago

@brianchirls Any chance you'll merge this and #4 soon?

brianchirls commented 8 years ago

Please see the comment in #4: I'm putting off that change indefinitely.

As for the npm release, how about now? Does now work for you?

sindrenm commented 8 years ago

:+1: