search

brianchoon / pe

0 stars 0 forks source link

Editing student-only attributes on teachers will show confusing and misleading error message #14

Open brianchoon opened 5 days ago

brianchoon commented 5 days ago

I understand that in the planned enhancements, this is expected to be fixed.

image.png

However, it is still extremely misleading for users if they edit such fields (e.g. nok) for teachers.

For example, I tried to edit the next-of-kin for a teacher, and the message shown is this:

image.png

It says Edited Person: which is incorrect as the teacher's details were not edited at all!

This may cause a lot of confusion and panic among users as the app is claiming that it has edited something but the user does not know what is edited.

nus-se-bot commented 1 day ago

Team's Response

As you've mentioned, we've already specified in the Planned Enhancements that we will prevent users from editing such student-specific fields for a teacher. Implementing that will prevent users from seeing this confusing behavior.

Items for the Tester to Verify

:question: Issue response

Team chose [response.Rejected]

Reason for disagreement: [replace this with your explanation]