search

brianchoon / pe

0 stars 0 forks source link

First command skipped when iterating down history of commands #4

Open brianchoon opened 5 days ago

brianchoon commented 5 days ago

I have one student in the list at the start.

I did these commands in this order: edit 1 /name A edit 1 /name B edit 1 /name C edit 1 /name D

Now, when I toggled through the history of commands by pressing the up button, this is what I see (in order, per up button clicked): edit 1 /name D edit 1 /name C edit 1 /name B edit 1 /name A (i.e. blank)

Now, I go through the history in the opposite direction, but this is what I see (in order, per down button clicked): edit 1 /name B edit 1 /name C edit 1 /name D (i.e. blank)

As you can see, the very first command, edit 1 /name A, was not displayed.

To fix this bug, I believe they may be an issue with how you're keeping track of the command index in the history. It is worth having a look!

soc-pe-bot commented 1 day ago

Team's Response

Thank you for the feedback! Good catch!

Items for the Tester to Verify

:question: Issue severity

Team chose [severity.Low] Originally [severity.Medium]

Reason for disagreement: Thank you for your response. I would like to quote the severity level on the CS2103T website, which states:

severity.Low : A flaw that is unlikely to affect normal operations of the product. Appears only in very rare situations and causes a minor inconvenience only.
severity.Medium : A flaw that causes occasional inconvenience to some users, but they can continue to use the product.

Instead, I still stand by my original category of severity.Medium, as it is true that this flaw will cause occasionally inconvenience to users. For example, if they scroll to the start, then try and access the first command, they will have to go to second command, then go back up to first command (this introduces an additional keystroke). Nevertheless, it is still possible to use your product as this history feature just improves efficiency.

However, I do not think it is severity.Low as it is actually quite common that users may cycle through the list of commands and accidentally end up at the end.