briancoyner / Core-Animation-Fun-House

Core Animation Examples (Basics, Replicator, Reflection, Wiggle Jiggle, Lissajous Curve, Sine Wave, etc.)
252 stars 65 forks source link

Are you interested in an updated project? #2

Open Motti-Shneor opened 3 years ago

Motti-Shneor commented 3 years ago

Downloaded this beautiful set of samples, and of course I was immediately blocked by hostile Xcode 12.4, MacOS 11.x iOS 15 and all the changes and deprecations.

Happily, your project was so clean and tidy, that in just 30 min I could make it shine again (zero warnings, and running nicely).

Moreover - on MacOS 11.5 and Xcode 12.4 (both no longer "latest", but fairly new) this runs directly on Mac -- even without a simulator!!! I tested it a little and was very pleased.

I wonder if you're interested in a branch + pull-request with these updates.

Also missing is a real MacOS adaptation. I'm really frustrated not finding ANY MacOS sample code for CoreGraphics and CoreAnimation for Mac AppKit. So... adding a native MacOS target could also make great value.

Let me know what you think...

briancoyner commented 3 years ago

Hi Motti,

Feel free to open a pull request with the changes. I am fine if you want to upgrade to target iOS 15+. I’ll take a look as soon as I can. Thanks for reaching out.

Brian

On Nov 8, 2021, at 6:35 AM, Motti Shneor @.***> wrote:

Downloaded this beautiful set of samples, and of course I was immediately blocked by hostile Xcode 12.4, MacOS 11.x iOS 15 and all the changes and deprecations.

Happily, your project was so clean and tidy, that in just 30 min I could make it shine again (zero warnings, and running nicely).

Moreover - on MacOS 11.5 and Xcode 12.4 (both no longer "latest", but fairly new) this runs directly on Mac -- even without a simulator!!! I tested it a little and was very pleased.

I wonder if you're interested in a branch + pull-request with these updates.

Also missing is a real MacOS adaptation. I'm really frustrated not finding ANY MacOS sample code for CoreGraphics and CoreAnimation for Mac AppKit. So... adding a native MacOS target could also make great value.

Let me know what you think...

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/briancoyner/Core-Animation-Fun-House/issues/2, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAGHA5YDBSHOCCAVIM4YNJDUK67XPANCNFSM5HSRYY7Q. Triage notifications on the go with GitHub Mobile for iOS https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Android https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.

cntrump commented 2 years ago

Try my pr: https://github.com/briancoyner/Core-Animation-Fun-House/pull/3