briancurtin / deprecation

A library to handle automated deprecations
Apache License 2.0
88 stars 31 forks source link

Allow removed_in to be a date #47

Closed aakum03 closed 4 years ago

aakum03 commented 4 years ago

Added support to input the removed_inparameter to be of type datetime.date in deprecation.py. Modified docstrings to explain/include this feature. Note: Input Date using date(2020, 1, 31) as this follows a YYYY-MM-DD format.

Added 9 more tests case to test_deprecation.py to test this feature

Closes #46

codecov-io commented 4 years ago

Codecov Report

Merging #47 into master will not change coverage. The diff coverage is 100%.

Impacted file tree graph

@@          Coverage Diff          @@
##           master    #47   +/-   ##
=====================================
  Coverage     100%   100%           
=====================================
  Files           1      1           
  Lines          83     88    +5     
  Branches       16     18    +2     
=====================================
+ Hits           83     88    +5
Impacted Files Coverage Δ
deprecation.py 100% <100%> (ø) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 264e8cd...633dba6. Read the comment docs.

gabbard commented 4 years ago

@aakum03 : I have not yet reviewed the tests. I will look at them on Monday.

aakum03 commented 4 years ago

Made the requested changes to deprecation.py

briancurtin commented 4 years ago

Thanks a lot for this PR, and thanks @gabbard for having a look as well. I'll give it a full review in the next day or so.

briancurtin commented 4 years ago

Thanks for the PR! I'm going to merge it and then will put together a release probably later today or early tomorrow, then I'll close out #46 once it's available.

briancurtin commented 4 years ago

Hey, sorry for the long delay on this, but I released 2.1.0 which includes this fix. Thanks again for the PR!

gabbard commented 4 years ago

@briancurtin : No problem. Thanks!