Closed aakum03 closed 4 years ago
Merging #47 into master will not change coverage. The diff coverage is
100%
.
@@ Coverage Diff @@
## master #47 +/- ##
=====================================
Coverage 100% 100%
=====================================
Files 1 1
Lines 83 88 +5
Branches 16 18 +2
=====================================
+ Hits 83 88 +5
Impacted Files | Coverage Δ | |
---|---|---|
deprecation.py | 100% <100%> (ø) |
:arrow_up: |
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact)
,ø = not affected
,? = missing data
Powered by Codecov. Last update 264e8cd...633dba6. Read the comment docs.
@aakum03 : I have not yet reviewed the tests. I will look at them on Monday.
Made the requested changes to deprecation.py
Thanks a lot for this PR, and thanks @gabbard for having a look as well. I'll give it a full review in the next day or so.
Thanks for the PR! I'm going to merge it and then will put together a release probably later today or early tomorrow, then I'll close out #46 once it's available.
Hey, sorry for the long delay on this, but I released 2.1.0 which includes this fix. Thanks again for the PR!
@briancurtin : No problem. Thanks!
Added support to input the
removed_in
parameter to be of typedatetime.date
indeprecation.py
. Modified docstrings to explain/include this feature. Note: Input Date usingdate(2020, 1, 31)
as this follows a YYYY-MM-DD format.Added 9 more tests case to
test_deprecation.py
to test this featureCloses #46