search

briancwald / material_admin

Drupal 8 Admin Theme
GNU General Public License v2.0
48 stars 15 forks source link

Module uninstall page checkboxes #2

Closed e0ipso closed 7 years ago

e0ipso commented 7 years ago

They are not the same as the checkboxes in the module install page. I'm assuming they should be the same.

briancwald commented 7 years ago

Yes, I had overlooked that page - I updated it to include the switch and labels that make sense.

screenshot 2017-05-12 15 10 20

Im going to keep this issue open though, I'd like to clean up the styling and add dropdown for the details of the module, similar to the module install page.

briancwald commented 7 years ago
screenshot 2017-05-16 08 11 33
briancwald commented 7 years ago

@e0ipso can you review this page?

e0ipso commented 7 years ago

It looks great!

If you are looking for feeback, may I suggest looking at the login page next? Do you want me to creat a new issue?

😊

briancwald commented 7 years ago

Hmm, typically the admin login is controlled by the front end theme but I'd imagine in your use case it's the same thing, I can take a look to see what is possible. Thanks!

briancwald commented 7 years ago

@e0ipso please, make any tickets, some ill be aware of but others I will miss.. there are so many templates in core! plus it keeps me motivated.