Style the Views exposed filter and bulk operations forms

briancwald / material_admin

Drupal 8 Admin Theme

GNU General Public License v2.0

48 stars 15 forks source link

Style the Views exposed filter and bulk operations forms #21

Closed mortenson closed 7 years ago

mortenson commented 7 years ago

This PR implements the concept from #18 to style the Views bulk operations and exposed filter forms.

briancwald commented 7 years ago

Loooking good! I see there are some merge conflicts with master because I have done a number of CSS/JS and SASS file cleanup we will need to resolve but the filters work great.

2 notes:

let's make the filter button flat, not jumping out.
I wonder if we can add the selected item's header to 'sticky-header' so s if you are on a page with long content you always see the actions visible. This basically is why core has 2 "submit" buttons on the page, which was a less useful attempt at dealign with that.

briancwald commented 7 years ago

I think its up to date now.

mortenson commented 7 years ago

I should have noted this in the first comment but the filter chips are also not implemented - do you want those added in this PR?

mortenson commented 7 years ago

@briancwald There were some remaining merge conflicts that broke styling of the bulk action ellipsis button, which should be fixed now.

For (1), I can't find a reference in http://materializecss.com/buttons.html or in the Material Design styleguide for a flat round (on hover) icon button. I'm also wondering if users would have a hard time knowing that they can click it if it was flat.

I'll work on (2), making the bulk operations header sticky.

briancwald commented 7 years ago

Yeah, so I'm thinking about it. Lets make that button a square, and then we can address the applied filters by just simply adding a 'badge' to the button when a filter is applied.