briandela / therealyou

hapi.js plugin for setting the request.info.remoteAddress and request.info.remotePort based on the X-Forwarded-For and X-Forwarded-Port headers
MIT License
7 stars 4 forks source link

Hapi v17 Support #7

Closed timcosta closed 5 years ago

timcosta commented 6 years ago

Overview

If you are not aware yet, Hapi v17 is making the transition from callbacks to async/await, as well as deprecating some other rarely used functionality. This is a breaking change that may make your plugin no longer compatible with the Hapi API.

Changelog

Draft release notes can be found here: https://github.com/hapijs/hapi/issues/3658

Target Release

The target release date for v17 is the beginning of November.

Tasks

Notes

mugli commented 6 years ago

Any update on this?

briandela commented 6 years ago

@mugli I'll take a PR for it but I don't have time right now for personal reasons

Y-LyN-10 commented 5 years ago

Looks-like that this plugin already supports Hapi v17 via #8 . It will be a good idea to close this issue :)

heskew commented 5 years ago

Good call @Y-LyN-10 👍