search

briandfoy / net-ssh-perl

Development on the Net::SSH::Perl module to support latest ciphers, key exchange mechanisms, etc.
Other
4 stars 1 forks source link

Padding byte interpreted as signed integer, should be unsigned #57

Open briandfoy opened 1 year ago

briandfoy commented 1 year ago

This ticket was imported from rt.cpan.org 118437

Hello,

I've just run across a problem connecting to some servers, which I believe to be the problem described here: https://fogbugz.bitvise.com/default.asp?WinSSHD.1.11700.2

Basically, Net::SSH::Perl works if the padding happens to be 127 or below, but it should work all the way up to 255. The symptom is for example "Corrupted padlen -102 on input".

The solution seems to be to change line 241 (in version 2.01) to 'unpack "C"' instead of 'unpack "c"'.

Thanks!

-Xan

briandfoy commented 1 year ago

from schwigon@cpan.org

Hi,

thanks for your report?

Is there any chance that you create a Pull Request on Lance Kinley's repo on github https://github.com/lkinley/Net-SSH-Perl so he can have a look? He is the main author behind current development.

Thanks, Steffen

On Wed Oct 19 11:38:52 2016, xan@biblionix.com wrote:

Hello,

I've just run across a problem connecting to some servers, which I believe to be the problem described here: https://fogbugz.bitvise.com/default.asp?WinSSHD.1.11700.2

Basically, Net::SSH::Perl works if the padding happens to be 127 or below, but it should work all the way up to 255. The symptom is for example "Corrupted padlen -102 on input".

The solution seems to be to change line 241 (in version 2.01) to 'unpack "C"' instead of 'unpack "c"'.

Thanks!

-Xan