search

briandk / granovaGG

Bob Pruzek and Jim Helmreich's implementation of Elemental Graphics for Analysis of Variance
Other
15 stars 4 forks source link

geom_rug_alt has no examples #117

Closed briandk closed 13 years ago

briandk commented 13 years ago

It could include

library(granovaGG)
p <- qplot(hwy, cty, data = mpg)

# Note the differences below in where the rug fringes appear
p + geom_rug()
p + geom_rug_alt()
WilDoane commented 13 years ago

I like that addition.

-Wil

William Doane http://DrDoane.com

On 2011 Sep 03, at 11:59, briandk wrote:

It could include

library(granovaGG)
p <- qplot(hwy, cty, data = mpg)

# Note the differences below in where the rug fringes appear
p + geom_rug()
p + geom_rug_alt()

Reply to this email directly or view it on GitHub: https://github.com/briandk/granovaGG/issues/117

briandk commented 13 years ago

It's proving to be really hard, with regard to documentation. The issue is that technically we've documented GeomRugAlt, but not geom_rug_alt. I'm working on it now.

On Sat, Sep 3, 2011 at 12:10 PM, WilDoane < reply@reply.github.com>wrote:

I like that addition.

-Wil

William Doane http://DrDoane.com

On 2011 Sep 03, at 11:59, briandk wrote:

It could include

library(granovaGG)
p <- qplot(hwy, cty, data = mpg)

# Note the differences below in where the rug fringes appear
p + geom_rug()
p + geom_rug_alt()

Reply to this email directly or view it on GitHub: https://github.com/briandk/granovaGG/issues/117

Reply to this email directly or view it on GitHub: https://github.com/briandk/granovaGG/issues/117#issuecomment-1987248

briandk commented 13 years ago

It also occurs to me that technically @hadley wrote this function - we just tweaked two lines. I'm thinking that either we should omit the "author" section for this documentation, or give Hadley credit first.

WilDoane commented 13 years ago

I would remove anyone from that list who didn't actually contribute to that file. So, Hadley + me and you, yes?

-Wil

William Doane http://DrDoane.com

On 2011 Sep 03, at 12:43, briandk wrote:

It also occurs to me that technically @hadley wrote this function - we just tweaked two lines. I'm thinking that either we should omit the "author" section for this documentation, or give Hadley credit first:

Author(s)

Hadley Wickham With contributions by: Brian A. Danielak Robert M. Pruzek William E. J. Doane Jason Bryer

briandk commented 13 years ago

@Wil that sounds right.

CerebralMastication commented 13 years ago

Just so you know, examples are always a good idea.