briandk / granovaGG

Bob Pruzek and Jim Helmreich's implementation of Elemental Graphics for Analysis of Variance
Other
15 stars 4 forks source link

Fixing granovaGG to be compatible with both ggplot2 v0.8.9 and v0.9.0 #139

Closed briandk closed 12 years ago

briandk commented 12 years ago

In addition to renaming some parameters, the main functional break occurs because of internal changes in ggplot2. As a result, I've updated the internals of our geom_rug_alt() function.

But, I also may have to make visual changes to our themes that could affect cross-version compatibility.

WilDoane commented 12 years ago

I think that's bound to happen and the key is in the documentation... making it clear what version of ggplot2 is being targeted.

-Wil

William Doane http://DrDoane.com

On 2012 Feb 05, at 15:14, Brian A. Danielak wrote:

In addition to renaming some parameters, the main functional break occurs because of internal changes in ggplot2. As a result, I've updated the internals of our geom_rug_alt() function.

But, I also may have to make visual changes to our themes that could affect cross-version compatibility.

You can merge this Pull Request by running:

git pull https://github.com/briandk/granovaGG ggplot2-v0-9-fix

Or you can view, comment on it, or merge it online at:

https://github.com/briandk/granovaGG/pull/139

-- Commit Summary --

  • Import required packages and require R 2.14 or greater
  • Replace "value" parameter with "values" in color scale calls
  • Pretty format geom_rug_alt and explicitly import proto()
  • Use Geom environment from ggplot2 namespace
  • Move geom_rug_alt() to its own file and exporting it

-- File Changes --

M DESCRIPTION (10) M NAMESPACE (3) A R/geom_rug_alt.R (71) M R/granovagg.1w.R (6) M R/granovagg.contr.R (1) M R/granovagg.ds.R (2) M R/shared-functions.R (64) M R/theme-defaults.R (1)

-- Patch Links --

https://github.com/briandk/granovaGG/pull/139.patch https://github.com/briandk/granovaGG/pull/139.diff


Reply to this email directly or view it on GitHub: https://github.com/briandk/granovaGG/pull/139