briandk / granovaGG

Bob Pruzek and Jim Helmreich's implementation of Elemental Graphics for Analysis of Variance
Other
15 stars 4 forks source link

Making granovaGG compatible with ggplot2 v 1.0 #156

Closed briandk closed 9 years ago

briandk commented 10 years ago

Hadley announced that ggplot2 will basically be going into maintenance mode after the 1.0 release. I received an email today that they plan to deploy ggplot2 1.0 on May 9, and Hadley/Winston helpfully ran reverse-dependency checks for all packages that depend on ggplot2.

We're actually in the green, according to our package check.

There were 3 NOTES (recall that NOTES won't cause an R CMD check to fail; only WARNINGS will), which at some point if I have time I will try to fix:

1. On the package build process our README isn't getting ignored

* checking top-level files ... NOTE
Non-standard file/directory found at top level:
  'README.markdown'

Source

2. The usual dumb binding warnings I'm not going to fix

* checking R code for possible problems ... NOTE
GrandMeanPoint: no visible binding for global variable 'score'
JitteredScoresByGroupContrast: no visible binding for global variable
  'contrast'
JitteredScoresByGroupContrast: no visible binding for global variable
  'score'

Source

3. A line may be getting truncated in our PDF manual

* checking Rd line widths ... NOTE
Rd file 'granovagg.ds.Rd':
  \examples lines wider than 100 characters:
                  main = "Assessment Plot for weights to assess Family Therapy treatment for Anorexia Patients",

These lines will be truncated in the PDF manual.

Source

briandk commented 10 years ago

Actually, I think that third warning is bogus. Here's a snapshot from our PDF manual:

cran_r-project_org_web_packages_granovagg_granovagg_pdf

So, I think the only real problem we need to solve is ignoring the README file.

briandk commented 9 years ago

Seems like fixing #157 fixed this, so ima close it.