Closed cureos closed 11 years ago
briandonahue
commented
11 years ago Hi Anders,
I've added you as a committer to the library since I haven't really been using it much lately, and I am glad someone is trying to update it for current use cases! I'm also making you an owner of the nuget package, too. You seem to have a good handle on what needs to be done - but let me know if there is anything else you need from me.
Thanks!
Brian
cureos
commented
11 years ago Thanks Brian,
I will try to push updated code to your repository in the near future, and also create an updated Nuget package. I'll let you know about the progress.
Best regards, Anders
cureos
commented
11 years ago Brian,
I have now added a PCL project to the FJCore solution, made code modifications corresponding to the pull request and made some minor solution and project clean-ups. The Image.ToBitmap method is for obvious reasons only available in the Windows Forms project, otherwise the portable library contains all functionality of the Winforms and Silverlight dedicated libraries. Furthermore, some performance tweaks that are used in the Winforms project are not applied in the portable library, meaning that the portable library could be less efficient than the Winforms library for large images.
When time permits, I will create a new NuGet package as well. Do you have any opinion on the version numbering? 0.7.1? 0.8.0?
Best regards, Anders
briandonahue
commented
11 years ago Hi Anders,
I don't really have a strong opinion. If I had to suggest, I'd probably say 0.7.1 because there is not a major functional change, but you can make the final call. Glad to see it getting some love! I was using it for a Silverlight photo upload tool that I've since abandoned and just switched to PlUpload :)
On Tue, Aug 13, 2013 at 5:07 PM, Anders Gustafsson <notifications@github.com
wrote:
Brian,
I have now added a PCL project to the FJCore solution, made code modifications corresponding to the pull request and made some minor solution and project clean-ups. The Image.ToBitmap method is for obvious reasons only available in the Windows Forms project, otherwise the portable library contains all functionality of the Winforms and Silverlight dedicated libraries. Furthermore, some performance tweaks that are used in the Winforms project are not applied in the portable library, meaning that the portable library could be less efficient than the Winforms library for large images.
When time permits, I will create a new NuGet package as well. Do you have any opinion on the version numbering? 0.7.1? 0.8.0?
Best regards, Anders
— Reply to this email directly or view it on GitHubhttps://github.com/briandonahue/FluxJpeg.Core/pull/2#issuecomment-22597603 .
cureos
commented
11 years ago Hi again Brian,
version 0.7.1 is now published on NuGet, incorporating all three DLL:s (.NET 3.5, Silverlight 5 and PCL) but no PDB files. I took the liberty of editing the Github README file at the same time, I hope you don't mind.
Best regards, Anders
briandonahue
commented
11 years ago Awesome! Looks good to me!
Dear Brian,
(quite) a while ago I forked your FluxJpeg.Core repository in order to adapt the library to become as portable as possible. With only a few modifications I have made it possible to build a Portable Class Library of FJCore that can target Windows Store/8 applications, Windows Phone version 7 and higher, .NET Framework version 4 and higher, and Silverlight version 4 and higher.
I notice that you have published a Silverlight (?) version of FJCore on Nuget, and I think that's great. If you would like to offer FJCore for the other targets as well (Windows Store, Windows Phone, .NET), then please consider pulling in this request and publish the PCL library on Nuget. I think it would be a terrific addition to the library that you have already uploaded.
Best regards, Anders @ Cureos